asyncio: Fix type of add_child_handler callback #11548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It takes two int arguments (the pid and return code) and only then takes the unpacked *args passed to add_child_handler(). See the docstring: https://github.com/python/cpython/blob/3cdfdc07a9dd39bcd6855b8c104584f9c34624f2/Lib/asyncio/unix_events.py#L901
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Mar 9, 2024
allisonkarlitskaya
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Apr 30, 2024
This brings in a buggy definition in the version of the typeshed included in the new container image. Add an #ignore. See python/typeshed#11548 Closes #20372
allisonkarlitskaya
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Apr 30, 2024
This brings in a buggy definition in the version of the typeshed included in the new container image. Add an #ignore. See python/typeshed#11548 Closes #20372
allisonkarlitskaya
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Apr 30, 2024
This brings in a buggy definition in the version of the typeshed included in the new container image. Add an #ignore. See python/typeshed#11548 Closes #20372
allisonkarlitskaya
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Apr 30, 2024
This brings in a buggy definition in the version of the typeshed included in the new container image. Add an #ignore. See python/typeshed#11548 Closes #20372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes two int arguments (the pid and return code) and only then takes the unpacked *args passed to add_child_handler(). See the docstring: https://github.com/python/cpython/blob/3cdfdc07a9dd39bcd6855b8c104584f9c34624f2/Lib/asyncio/unix_events.py#L901