Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve stubtest allowlist entries for ldap3 #9532

Merged
merged 3 commits into from
Jan 14, 2023

Conversation

Avasam
Copy link
Sponsor Collaborator

@Avasam Avasam commented Jan 14, 2023

No description provided.

@AlexWaygood
Copy link
Member

Looks like there's a bug in check_consistent.py. This line:

specified_stubtest_platforms = set(tool_stubtest.get("platforms", []))

Should be changed to:

specified_stubtest_platforms = set(tool_stubtest.get("platforms", ["linux"])) 

Feel free to fix it as part of this PR!

@AlexWaygood
Copy link
Member

On second thoughts, I'll send a PR to centralize metadata parsing in our tests. It'll reduce the risk of future bugs like this, and also be more type-safe.

@Avasam
Copy link
Sponsor Collaborator Author

Avasam commented Jan 14, 2023

On second thoughts, I'll send a PR to centralize metadata parsing in our tests. It'll reduce the risk of future bugs like this, and also be more type-safe.

That's actually something that's been nagging me at the back of my mind for a while. And even commented with hauntsaninja: #9298 (comment)
Reduce code duplication. Increased type safety for typeshed's own testing code. Consistent defaults. Easier for contributors. etc.
I think it could be a good idea to centralize it even across projects: https://github.com/typeshed-internal/stub_uploader/blob/main/stub_uploader/metadata.py

@AlexWaygood
Copy link
Member

Feel free to do the easy fix for check_consistent.py as part of this PR! I don't want to hold this PR up until another maintainer's had a chance to review #9534.

@AlexWaygood AlexWaygood changed the title Use gssapi in ldap3 Resolve stubtest allowlist entries for ldap3 Jan 14, 2023
@AlexWaygood AlexWaygood merged commit 0e36622 into python:main Jan 14, 2023
@Avasam Avasam deleted the gssapi-in-ldap3 branch January 14, 2023 18:21
Avasam added a commit to Avasam/typeshed that referenced this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants