-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add warp transducer #1099
Closed
Closed
add warp transducer #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentqb
force-pushed
the
warp-transducer
branch
13 times, most recently
from
December 18, 2020 23:54
108b5b9
to
318a94d
Compare
vincentqb
commented
Dec 19, 2020
vincentqb
force-pushed
the
warp-transducer
branch
2 times, most recently
from
December 21, 2020 23:45
f939ad7
to
97de03b
Compare
vincentqb
commented
Dec 22, 2020
vincentqb
force-pushed
the
warp-transducer
branch
2 times, most recently
from
December 23, 2020 15:39
afd3965
to
7663661
Compare
vincentqb
force-pushed
the
warp-transducer
branch
3 times, most recently
from
December 23, 2020 16:26
f0445a5
to
1cf829f
Compare
vincentqb
force-pushed
the
warp-transducer
branch
from
December 23, 2020 16:41
1cf829f
to
40ff36a
Compare
cpuhrsch
reviewed
Dec 23, 2020
@@ -83,7 +84,8 @@ def run(self): | |||
packages=find_packages(exclude=["build*", "test*", "torchaudio.csrc*", "third_party*", "build_tools*"]), | |||
ext_modules=setup_helpers.get_ext_modules(), | |||
cmdclass={ | |||
'build_ext': setup_helpers.BuildExtension.with_options(no_python_abi_suffix=True) | |||
'build_ext': setup_helpers.BuildExtension.with_options(no_python_abi_suffix=True), | |||
'clean': clean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
cpuhrsch
reviewed
Dec 23, 2020
|
||
try: | ||
torch.ops.warprnnt_pytorch_warp_rnnt.gpu_rnnt | ||
_CUDA_TRANSDUCER = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make this switch dependent on whether CUDA is available at all.
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
…PI and deprecate the old one (pytorch#1099) * [PT-D][Tensor Parallel] Update the example for TP to use DTensor and new TP API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces
rnnt_loss
andRNNTLoss
intorchaudio.prototype.transducer
using HawkAaron's warp-transducer.cmdclass
to use custom clean here.Import the warp-transducer repository
Suggested options to load the repository with torchbind replacing pybind:
git subtree
as suggested in comment.CUDA
This pull request can optionally build with GPU support. Environment variables need to be set before installing, as mentioned here and colab notebook.
There is also a a unit test available for GPU.
cc @astaff, internal