Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental windows builds #219

Closed
wants to merge 8 commits into from
Closed

Experimental windows builds #219

wants to merge 8 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 7, 2019

cc @peterjc123

Signed-off-by: Edward Z. Yang ezyang@fb.com

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@peterjc123
Copy link
Contributor

@ezyang I believe this repo is not Windows-ready because it relies on sox that cannot be built statically.

@ezyang
Copy link
Contributor Author

ezyang commented Aug 8, 2019

Yeah, I think I agree

@HsunGong
Copy link

Yeah, I think I agree

Maybe use socket of WSL in order to get sox info ?? Seems feasible.

@peterjc123
Copy link
Contributor

This is not a good idea. First, it requires users to install WSL. It's a win 10 only feature. Second, if there's WSL, why don't we just run code in WSL? Nevertheless, it may be helpful if you want to use native libraries with torchaudio. But apparently, this is not something we should do here.

@black-snow
Copy link

Second, if there's WSL, why don't we just run code in WSL?

Because it still has no CUDA support.

@peterjc123
Copy link
Contributor

peterjc123 commented May 23, 2020

@black-snow They actually announced that several days ago. But the discussion here is rather old. We have torchaudio nightly packages for Windows now. As for torchaudio with sox, you can see #648.

@black-snow
Copy link

@black-snow They actually announced that several days ago. But the discussion here is rather old. We have torchaudio nightly packages for Windows now.

Thanks for the reply. Yes they did but only for WSL2 and for that you still have to be on insider/fast-ring (although the may update should be out soon).

How do I get the nightly? For now, I only need torchaudio.datasets (which uses torchaudio.load but I don't know if that requires sox already).

@peterjc123
Copy link
Contributor

peterjc123 commented May 23, 2020

@black-snow

# Conda
conda install -c pytorch-nightly torchaudio
pip install pySoundFile
# Pip
pip install -f https://download.pytorch.org/whl/nightly/torch_nightly.html torchaudio

@mthrok
Copy link
Collaborator

mthrok commented Mar 6, 2021

Addressed by #1345

@mthrok mthrok closed this Mar 6, 2021
@mthrok mthrok deleted the pr/windows-builds branch May 27, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants