-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows CI #394
Add Windows CI #394
Conversation
cc @vincentqb Should be ready. However, no tests are running at current. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
However, no tests are running at current.
Have you tried running them at all? Of course, a few depend on sox and will fail.
import torch | ||
|
||
from . import _soundfile_backend, _sox_backend | ||
|
||
|
||
_audio_backend = "sox" | ||
_audio_backend = "soundfile" if platform.system() == "Windows" else "sox" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You recommend making soundfile the default in windows? If that is the case, I'm thinking we may want to make soundfile the default everywhere. Since we are doing the 0.4.0 release now, it may be a good idea to bring this in now so that we have window supported.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You recommend making soundfile the default in windows?
I made the change because I was not able to compile the sox backend on Windows. So actually, soundfile is the only available choice for Windows.
If that is the case, I'm thinking we may want to make soundfile the default everywhere.
The major limitation of soundfile is that it cannot read the file with the MP3 format, which is possible in sox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another difficulty I met is that there are no available pysoundfile packages hosted on Anaconda Cloud for Windows. Although the current one is marked as noarch, it is depending on a gcc package which is not available on Windows. So for conda users, the installation script will look a bit weird like this.
conda install -c pytorch torchaudio
pip install soundfile
Test results: https://gist.github.com/peterjc123/4f5b43ce372905c82333f7693a65a15c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Since sox is not an option on windows, we'll fall back to soundfile as you suggest.
No description provided.