-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on tests when building through conda-build #493
Conversation
@vincentqb The Windows tests are enabled here. You may use this PR for testing purposes. |
Rebased. |
Is it intentional that |
@vincentqb Nope, I used |
44900ad
to
c9cd1fb
Compare
Rebased and regenerated yaml. |
The windows build appear to get stuck at the same place:
|
Yes, I'm looking into it. Looks like a bug in conda-build that blocks installing wheel packages and using pytest. |
Well, it's weird because I cannot reproduce it on my machine. |
@vincentqb Could you please give me some write permission to this repo so that I can debug using this tutorial? Currently, I cannot rerun a CircleCI job with SSH. |
@vincentqb It seems that the tests in |
@vincentqb There's only one test failing now: |
I'm ok skipping this test on windows for now.
|
@vincentqb Test failures are unrelated. Do you want to get this into master? |
Yes, I would like to merge this PR in.
|
Yes, we should simply rename the prefix of the current working job into
Yes, and that will fairly easy since torchaudio on Windows will be a Python-only package. |
@vincentqb The unittest jobs are enabled in #604. |
Closed by #604 |
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Relates to #425