Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Update QgsServerFilter cookbook documentation #6949

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

dmarteau
Copy link
Contributor

Update QgsServerFilter documentation according to qgis/QGIS#45158

Also fix some errors about how QgsServerFilter callbacks are called during the processing of the response.

@elpaso
Copy link
Contributor

elpaso commented Sep 23, 2021

Note: please wait to merge this one until qgis/QGIS#45158 is merged

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmarteau
I made some "cosmetic" comments. I'll let server gurus approve the contents.

docs/pyqgis_developer_cookbook/server.rst Outdated Show resolved Hide resolved
docs/pyqgis_developer_cookbook/server.rst Outdated Show resolved Hide resolved
docs/pyqgis_developer_cookbook/server.rst Outdated Show resolved Hide resolved
docs/pyqgis_developer_cookbook/server.rst Outdated Show resolved Hide resolved
docs/pyqgis_developer_cookbook/server.rst Outdated Show resolved Hide resolved
@DelazJ
Copy link
Collaborator

DelazJ commented Sep 24, 2021

Thanks @dmarteau
I approved to trigger the build checks.

@dmarteau
Copy link
Contributor Author

I don't know how to fix:

/home/runner/work/QGIS-Documentation/QGIS-Documentation/docs/pyqgis_developer_cookbook/server.rst:369: 
WARNING: py:meth reference target not found: qgis.server.QgsServerFilter.onSendResponse

@DelazJ
Copy link
Collaborator

DelazJ commented Sep 24, 2021

No worries. As soon as the code is merged in master and pyQGIS API docs generated, those references will be available

@DelazJ
Copy link
Collaborator

DelazJ commented Nov 18, 2021

@dmarteau Now that the feature PR is merged, can you rebase this one please?
@elpaso OK to merge?

@DelazJ DelazJ added 3.24 QGIS 3.24 new features Server QGIS Server related labels Dec 24, 2021
Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

docs/pyqgis_developer_cookbook/server.rst Outdated Show resolved Hide resolved
docs/pyqgis_developer_cookbook/server.rst Outdated Show resolved Hide resolved
@DelazJ DelazJ enabled auto-merge (rebase) February 11, 2022 07:58
@DelazJ DelazJ merged commit a402b40 into qgis:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.24 QGIS 3.24 new features Server QGIS Server related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants