Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] [Processing] Catch some python errors in batch mode #2804

Merged
merged 2 commits into from
Mar 3, 2016

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Feb 17, 2016

Problem

If the user clicks on "cancel" or if the JSON file is not valid, a python exception was raised.

I've updated an error message in the modeler too.

CC

@volaya @alexbruy

@Gustry
Copy link
Contributor Author

Gustry commented Feb 26, 2016

@volaya and @alexbruy Is there any reason why is not going to be merged for 2.14 in a few hours ?

@Gustry Gustry changed the title Catch some python errors in batch processing [Bugfix] [Processing] Catch some python errors in batch mode Feb 26, 2016
@volaya
Copy link
Contributor

volaya commented Mar 3, 2016

looks good to me. Sorry that i did not review it before

volaya added a commit that referenced this pull request Mar 3, 2016
[Bugfix] [Processing] Catch some python errors in batch mode
@volaya volaya merged commit b3b4101 into qgis:master Mar 3, 2016
@Gustry
Copy link
Contributor Author

Gustry commented Mar 3, 2016

Thanks @volaya
@luipir This fix was related to some GUI tools (after a click on the save button) so I don't think there is any problem about the MessageBox.

@Gustry Gustry deleted the processing-error branch March 3, 2016 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants