Fix out of bounds array access if nextVertex is called on empty geometry collection #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ometryCollectionV2
|
Mind adding a quick regression test protecting against this too? |
|
Sure, something like 6e5e7e4? |
|
Does that test work? I can't see it calling nextVertex? In any case, I'd strongly suggest moving it to testqgsgeometry.cpp to avoid the need for creating a new cpp test file (which slows compilation down) |
|
Ok (yes, the test works, because isEmpty uses nextVertex - the usage of isEmpty was what actually caused the crash in the geometry checker). |
|
Ah ok - i should have actually looked at the code ;) |
nyalldawson
added a commit
that referenced
this pull request
Mar 6, 2016
Fix out of bounds array access if nextVertex is called on empty geometry collection
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a geometry checker crash reported in #13535.