Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alias and copy iguana #117

Merged
merged 12 commits into from
Aug 18, 2023
Merged

add alias and copy iguana #117

merged 12 commits into from
Aug 18, 2023

Conversation

Jacyking
Copy link
Collaborator

No description provided.

Comment on lines 618 to 624
static std::string alisa_fields; \
for (const auto &it : arr()) { \
alisa_fields += it.data(); \
alisa_fields += ","; \
} \
alisa_fields.back() = ' '; \
return alisa_fields; \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(!alisa_fields.empty()) {
  return alisa_fields
}

// do init ...

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 79.54% and project coverage change: +0.72% 🎉

Comparison is base (fa07ca6) 39.34% compared to head (53ad6ef) 40.07%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   39.34%   40.07%   +0.72%     
==========================================
  Files          21       22       +1     
  Lines        2821     2852      +31     
==========================================
+ Hits         1110     1143      +33     
+ Misses       1711     1709       -2     
Files Changed Coverage Δ
iguana/define.h 0.00% <ø> (ø)
iguana/detail/charconv.h 0.00% <ø> (ø)
iguana/json_reader.hpp 0.00% <0.00%> (ø)
iguana/json_util.hpp 0.00% <ø> (ø)
iguana/util.hpp 0.00% <0.00%> (ø)
iguana/reflection.hpp 100.00% <100.00%> (ø)
include/mysql.hpp 84.98% <100.00%> (+0.58%) ⬆️
include/utility.hpp 97.89% <100.00%> (+0.22%) ⬆️
tests/test_ormpp.cpp 94.52% <100.00%> (+0.26%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit b882e9a into qicosmos:master Aug 18, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants