Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get insert id after insert #132

Merged
merged 6 commits into from
Dec 14, 2023
Merged

add get insert id after insert #132

merged 6 commits into from
Dec 14, 2023

Conversation

Jacyking
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (df75b98) 42.10% compared to head (ec30788) 42.23%.

Files Patch % Lines
include/mysql.hpp 77.41% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   42.10%   42.23%   +0.12%     
==========================================
  Files          22       22              
  Lines        2978     2986       +8     
==========================================
+ Hits         1254     1261       +7     
- Misses       1724     1725       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 133 to 135
std::optional<uint64_t> insert_id = {0};
insert_or_update_impl(t, generate_insert_sql<T>(true), OptType::insert,
std::move(insert_id));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成

insert_or_update_impl(t, generate_insert_sql<T>(true), OptType::insert, 0);

数字可以直接赋值给optional的

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jacyking Jacyking merged commit 530ce35 into qicosmos:master Dec 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants