Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: migrate to Poetry & pyproject.toml #1387

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

mochaaP
Copy link

@mochaaP mochaaP commented Sep 23, 2023

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/API for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


Migrate the project to Poetry.

Supersedes #1111.

@mochaaP
Copy link
Author

mochaaP commented Jan 7, 2024

cc @xwings please review :)

@xwings
Copy link
Member

xwings commented Jan 8, 2024

code looks good to me. one more approve we are good to go

@mochaaP
Copy link
Author

mochaaP commented Jan 8, 2024

Any ideas on the eth_abi v4 thing? I literally have zero experience with Ethereum, updating to the new encode API resulted in a different bytecode being emitted.

@mochaaP
Copy link
Author

mochaaP commented Jan 8, 2024

@nullableVoidPtr Hi, do you have time to take a look at this, since you authored #1111?

pyproject.toml Outdated Show resolved Hide resolved
@wtdcode
Copy link
Member

wtdcode commented Jan 8, 2024

Looks good overall, but separating linting in a single commit would be fine. Anyway nice work!

This PR reminds me one thing, maybe we should really mention we only deal with python>=3.8 somewhere.

@wtdcode
Copy link
Member

wtdcode commented Jan 8, 2024

Just one more thing, could you test if the release CI breaks or not?

@mochaaP
Copy link
Author

mochaaP commented Jan 8, 2024

Just one more thing, could you test if the release CI breaks or not?

I tested it on my local machine with a dry run, no issue so far.

@xwings
Copy link
Member

xwings commented Jan 9, 2024

CI seems to be good. @wtdcode you might need to approve the code

@xwings xwings merged commit 082b718 into qilingframework:dev Jan 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants