Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy docs to GitHub Pages #115

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

arnaucasau
Copy link
Contributor

@arnaucasau arnaucasau commented Dec 19, 2023

Summary

This PR changes the deploy-docs.yml workflow to deploy the documentation to GitHub Pages to migrate the project away from the qiskit.org domain.

More information about the change and a quick guide to set up GitHub pages can be found at: Qiskit/ecosystem#578

Reminder task for maintainers here to update the doc link in the About text for the repo on the main page once this change happens and the docs are re-deployed . This will need backporting to stable to have it apply to present docs version before it can be re-run.

  • Update About text doc link

@woodsp-ibm woodsp-ibm added documentation Improvements or additions to documentation stable backport potential The bug might be minimal and/or import enough to be port to stable labels Dec 19, 2023
@woodsp-ibm
Copy link
Member

FYI for CI failure see issue

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arnau for the PR, let's wait for testing-cabal/testtools#371 and see if the CI gets fixed once it's merged.

@woodsp-ibm
Copy link
Member

Once this is done the first section in the README, about installation, will need its link updating.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7492816091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.578%

Totals Coverage Status
Change from base Build 7492731210: 0.0%
Covered Lines: 6470
Relevant Lines: 7143

💛 - Coveralls

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnaucasau I have done a couple of workarounds to avoid the CI failures and as a result this can be moved forwards now. I think it's ready right.

Just as clarification, as I understand it, publishing is a 2 step process now, not just running this workflow. But now once its run the pages deployed to gh-pages need a second manual step to be published?

@arnaucasau
Copy link
Contributor Author

Great, thank you @woodsp-ibm! Regarding your question, I guess when you say publish it, you mean to qiskit.org, but correct me if I'm wrong.

We only need the first of the two steps you mentioned. With this workflow, the docs will be deployed to GitHub Pages where the documentation will live, and once this change is done, I will set up the redirects from qiskit.org to the GitHub Pages link we have.

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Jan 12, 2024

@arnaucasau I was reading it was "deployed" to a gh-pages branch - maybe thats all that there is to it and its live from there and needs no extra step. Once its backported I'll run the workflow.

@woodsp-ibm woodsp-ibm merged commit 402e470 into qiskit-community:main Jan 12, 2024
16 of 18 checks passed
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
(cherry picked from commit 402e470)
@arnaucasau
Copy link
Contributor Author

Oh, I see what you meant now. Exactly, we only need to deploy to the gh-pages branch, and the publish step is done automatically by a workflow called pages-build-deployment. The only important thing is to set the branch correctly in the settings. Here you can find a short tutorial I wrote: Qiskit/ecosystem#578 (comment)

mergify bot added a commit that referenced this pull request Jan 12, 2024
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
@woodsp-ibm
Copy link
Member

@arnaucasau Ok, I ran the workflow, updated the Settings and the docs are now live https://qiskit-community.github.io/qiskit-algorithms/ I guess a redirect for former ecosystem url can be done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants