Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Parametric Circuits #86

Closed
kshitijc opened this issue May 23, 2023 · 4 comments · Fixed by #96
Closed

Support for Parametric Circuits #86

kshitijc opened this issue May 23, 2023 · 4 comments · Fixed by #96
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kshitijc
Copy link
Collaborator

kshitijc commented May 23, 2023

What is the expected behavior?

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

A parametric Qiskit circuit should be converted to a Braket parametric circuit.
Currently, trying to convert a Qiskit parametric circuit to a Braket circuit like so:

from qiskit_braket_provider.providers.adapter import convert_qiskit_to_braket_circuit
from qiskit.circuit import Parameter

theta = Parameter('θ')
qc = QuantumCircuit(1, 1)
qc.rz(theta, 0)

yields the following error:

TypeError: ParameterExpression with unbound parameters ({Parameter(θ)}) cannot be cast to a float.

Expected outcome: This should return a Braket circuit with Rz gate and FreeParameter θ

@kshitijc kshitijc added enhancement New feature or request good first issue Good for newcomers labels May 23, 2023
@urihan
Copy link
Contributor

urihan commented May 27, 2023

Hello, I would like to work on this issue! Thank you

@king-p3nguin
Copy link
Contributor

king-p3nguin commented May 29, 2023

I'm also interested in working on this issue as part of the Unitary Hack. Can I be assigned to this challenge?
Thank you!

@natestemen
Copy link

@kshitijc this bounty is showing as completed by @urihan, but it looks like it was completed by @king-p3nguin. Please ensure the hacker who has been responsible to the issue being resolved is assigned to the issue. Thanks!

@JordanAWS JordanAWS assigned king-p3nguin and unassigned urihan Jun 2, 2023
@JordanAWS
Copy link
Collaborator

@natestemen Just updated. Could you update the UnitaryHack website to reflect @king-p3nguin as the bounty closer? https://unitaryhack.dev/projects/qiskit-braket-provider/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants