Support Parametric Circuits #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR @king-p3nguin! Could you please make updates to:
|
|
Thank you for the review! After fixing the bug, I ran tests locally, and everything appeared to be functioning correctly. |
kshitijc
reviewed
May 31, 2023
tests/providers/test_adapter.py
Outdated
| qiskit_circuit.rz(theta, 0) | ||
| braket_circuit = convert_qiskit_to_braket_circuit(qiskit_circuit) | ||
|
|
||
| braket_circuit_ans = Circuit().rz( # pylint: disable=no-member |
There was a problem hiding this comment.
Could we extend the test to include more complex gates like U3 and also mix parametric and non parametric gates?
There was a problem hiding this comment.
I noticed that the .u3 method is currently unavailable for QuantumCircuit. As a solution, I included UGate in the dictionary. Would this be acceptable?
Co-authored-by: Kshitij Chhabra <kshitijc@users.noreply.github.com>
kshitijc
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Great work @king-p3nguin! Thank you for this contribution! 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments