-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UnitaryHack] Mock provider, backend #107
Conversation
@JordanAWS Would could you give me some pointers to look upon for the failing test for test_real_device_circuit_execution ? |
@WingCode could you try replacing that with a deterministic circuit instead which has supported gates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @WingCode! The issue also calls for adding tests for the backend and job classes.
The coverage for these currently appears to be:
tests/providers/test_adapter.py .... [ 19%]
tests/providers/test_braket_backend.py .....s.sss.. [ 76%]
tests/providers/test_braket_job.py .. [ 85%]
Would you like to add the tests for backend and job in this PR?
@kshitijc Thank you for the review. Yes, I can add tests for lines not covered in |
@kshitijc Kindly let me know if you like some changes in this PR to get it merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @WingCode! Thanks for the improved coverage! 👍
Summary
Mocks backend, provider, job
Details and comments
closes #19