Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python versions: move from python 3.7 and add support for 3.11 #120

Conversation

robotAstray
Copy link
Contributor

@robotAstray robotAstray commented Aug 9, 2023

Summary:

This PR addresses issue #117 and #119 and enhances the testing capabilities across multiple Python versions, specifically 3.8, 3.9, 3.10, and 3.11.

Key Changes:

  • Modified .github/workflows/test_latest_versions.yml to include the following matrix configuration:
matrix:
        python-version: ["3.8", "3.9", "3.10", "3.11"]
  • Modified ./setup.py to include the following:
    classifiers=[
        ....
        "Programming Language :: Python :: 3.8",
        "Programming Language :: Python :: 3.9",
        "Programming Language :: Python :: 3.10",
        "Programming Language :: Python :: 3.11",
        "Topic :: Scientific/Engineering :: Physics",
    ],

and

python_requires=">=3.8.2",

This enhancement will allow testing across Python versions 3.8, 3.9, 3.10, and 3.11
@robotAstray robotAstray marked this pull request as ready for review August 9, 2023 10:56
@robotAstray
Copy link
Contributor Author

@IceKhan13 I have made the changes for issue 117

@robotAstray
Copy link
Contributor Author

I just switched this PR to draft, I will address issue #119 here since it is linked to this PR

@robotAstray robotAstray marked this pull request as draft August 9, 2023 17:41
@IceKhan13
Copy link
Member

@IceKhan13 IceKhan13 added the enhancement New feature or request label Aug 9, 2023
@robotAstray
Copy link
Contributor Author

robotAstray commented Aug 9, 2023

@IceKhan13 yes, that's right. I will also add the changes for setup.py. Once I am done I will mark the PR "Ready for review"

* updating python versions in setup.py

Update to the classifiers section to include "Programming Language :: Python :: 3.11" to match the requested support versions. In addition "Programming Language :: Python :: 3.7" was removed

* updating `python_requires` field in `setup.py` to version 3.8.2
@robotAstray robotAstray marked this pull request as ready for review August 9, 2023 19:32
@robotAstray
Copy link
Contributor Author

I think I made all the necessary changes @IceKhan13, let me know if you need anything else.

@christianbmadsen christianbmadsen merged commit a30bedf into qiskit-community:main Aug 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants