Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the U gate to translate Qiskit U-like gates #133

Merged

Conversation

jcjaskula-aws
Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws commented Dec 26, 2023

Summary

Replace Us decomposition by the application of a the Braket U gate.

Details and comments

Since U has been added to the Braket SDK, we simplify the implementation here.

Bump qiskit-terra version to solve an occurence of Qiskit/qiskit#7326

@jcjaskula-aws jcjaskula-aws changed the title Jcjaskula-aws/add_u_gate Use the U gate to translate Qiskit U-like gates Dec 26, 2023
Copy link
Collaborator

@ajberdy ajberdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to merge post 3.8 deprecation

@jcjaskula-aws jcjaskula-aws marked this pull request as draft February 7, 2024 21:55
@speller26
Copy link
Collaborator

I think this is actually still worth finishing without waiting for the service; the service doesn't support the U gate, but the same goes for control modifiers, which are supported in the provider.

@jcjaskula-aws jcjaskula-aws marked this pull request as ready for review February 9, 2024 00:11
@jcjaskula-aws
Copy link
Collaborator Author

jcjaskula-aws commented Feb 9, 2024

I think this is actually still worth finishing without waiting for the service; the service doesn't support the U gate, but the same goes for control modifiers, which are supported in the provider.

I'm not sure the service handles more gracefully U gates than control modifiers. We could try and fix it if it is a real issue.

Copy link
Collaborator

@speller26 speller26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the service handles more gracefully U gates than control modifiers. We could try and fix it if it is a real issue.

The way I see it, since the service supports neither control modifiers nor $U$ gates, but we've introduced the former anyway due to its support in the local simulator, we might as well do the same for the latter.

This can also help remind users of the full capabilities of the local simulator.

@speller26 speller26 merged commit c70791a into qiskit-community:main Feb 9, 2024
7 checks passed
@jcjaskula-aws jcjaskula-aws deleted the jcjaskula-aws/add_u_gate branch February 9, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants