fix a misused 2-qubit sample result type #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajberdy
reviewed
Dec 29, 2023
ajberdy
approved these changes
Dec 29, 2023
|
Probably orthogonal to this change, but it looks like the buggy code was originally added to fix an issue when a circuit has multiple registers: #51. Do you know if that scenario works now? |
Yes, I added a test to confirm that using multiple registers works correctly out-of-the-box. |
rmshaffer
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Measure instructions were wrongly translated. We now construct a 1-qubit sampling instruction.
Details and comments
We were translating a 1-qubit measure instruction into a 2-qubit ZZ observable sampling instruction (using the classical register index for the second qubit). This PR uses the right instruction and renames most of the variables in the function to be clearer.
Fixes #132.