generated from qiskit-community/quantum-prototype-template
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert braket circuits to qiskit circuits #136
Merged
speller26
merged 33 commits into
qiskit-community:main
from
jcjaskula-aws:jcjaskula-aws/from_braket
Feb 5, 2024
Merged
Convert braket circuits to qiskit circuits #136
speller26
merged 33 commits into
qiskit-community:main
from
jcjaskula-aws:jcjaskula-aws/from_braket
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjaskula-aws
force-pushed
the
jcjaskula-aws/from_braket
branch
from
January 29, 2024 20:45
40ccabb
to
e37f529
Compare
laurencap
requested changes
Jan 30, 2024
laurencap
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
speller26
reviewed
Feb 3, 2024
speller26
approved these changes
Feb 5, 2024
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a
to_qiskit
method to convert BraketCircuit
s to QiskitQuantumCircuit
s.Details and comments
We keep track of the free parameter names to reuse them if they appear several times in the circuits. Because the dicts construct parametric gates with a standalone
Parameter
, one needs to extra the class object to recreate a new gate with the right circuit Parameters.We add a
measure_all
instruction at the end because Braket measure all qubits.