Use device-specific gatesets for transpilation #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speller26
changed the title
There was a problem hiding this comment.
- Requested few straightforward changes (hopefully).
- Tests are missing.
- we could close Decompose circuits onto the native gate set of the backend #138
|
As far as tests go, the existing tests actually cover the implementation changes, since the transpiler target gatesets change in the tests too; an incorrect translation will lead to mismatch between the Aer and Braket simulations. |
|
Alright, approving but feel free to give some thoughts about #141 (comment). As for the tests, you are right. I just feel a bit uncomfortable that the transpiler mixes everything and our tests become less specific. |
jcjaskula-aws
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, the adapter transpiles circuits to a target gateset of all gates supported by Braket, which can cause problems if the device itself doesn't support a gate. This PR changes the adapter to transpile to the device's target gateset.
Details and comments
For devices that support control modifiers, named controlled gates that are not already in Braket will be translated to the corresponding uncontrolled gate with control modifiers applied.