Skip transpilation for verbatim circuits #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about cherry-picking these lines and deleting |
speller26
changed the title
jcjaskula-aws
approved these changes
Feb 8, 2024
| def _get_gateset(self) -> Optional[set[str]]: | ||
| action = self._device.properties.action.get(DeviceActionType.OPENQASM) | ||
| if not action: | ||
| return None |
There was a problem hiding this comment.
Just wonder if we want to keep full control of the gate set (i.e. returning set(BRAKET_TO_QISKIT_NAMES.values())) instead of letting Qiskit choose the gateset.
There was a problem hiding this comment.
to_braket actually uses _TRANSLATABLE_QISKIT_GATE_NAMES when gateset=None, so the gateset is in fact always controlled by the provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Circuits are no longer translated when
verbatimargument is passed torun.Details and comments
Also expands the supported gates check to both
BraketLocalBackendandAWSBraketBackend.