Move gateset construction to adapter #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speller26
changed the title
jcjaskula-aws
approved these changes
Feb 8, 2024
| gateset: Optional[Iterable[str]] = None, | ||
| basis_gates: Optional[ | ||
| Iterable[str] | ||
| ] = None, # TODO: Use backend instead of basis_gates |
There was a problem hiding this comment.
Note: I like passing list[str] that is simpler than a Backend. One could tweak their circuits for a certain gateset that they'd like to try.
At some point, I think we should expose to_braket and to_qiskit at higher level.
There was a problem hiding this comment.
That makes sense; this TODO was motivated by looking at all the work put into constructing a Target only to never use it.
speller26
commented
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Put gateset construction in a more logical place and made constants and methods private as needed.
Details and comments
Also skip gateset construction when running circuits verbatim.