generated from qiskit-community/quantum-prototype-template
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all gates in simulator targets #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speller26
changed the title
Include all gates in simulator targets
Include all gates in targets
Feb 9, 2024
speller26
changed the title
Include all gates in targets
Include all gates in simulator targets
Feb 9, 2024
jcjaskula-aws
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jcjaskula-aws
approved these changes
Feb 9, 2024
speller26
commented
Feb 9, 2024
speller26
commented
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments
Prior to this change, simulator targets and QPU targets alike were limited to up to 2q gates. Although no Braket devices are subject to these restrictions, this restriction still makes sense for QPUs because there is no analog of coupling map (and corresponding properties) for 3+ qubits. However, Braket simulators do not have a notion of coupling map, and gates can be applied to any qubit without impacting result quality. As such, this change removes this restriction for simulators.