Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all gates in simulator targets #147

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Include all gates in simulator targets #147

merged 8 commits into from
Feb 9, 2024

Conversation

speller26
Copy link
Collaborator

@speller26 speller26 commented Feb 9, 2024

Summary

  • Simulator targets now include all gates, regardless of qubit count
  • Major refactor to make code more readable, with functions being extracted as appropriate
  • Adds the device qubit count to the target.

Details and comments

Prior to this change, simulator targets and QPU targets alike were limited to up to 2q gates. Although no Braket devices are subject to these restrictions, this restriction still makes sense for QPUs because there is no analog of coupling map (and corresponding properties) for 3+ qubits. However, Braket simulators do not have a notion of coupling map, and gates can be applied to any qubit without impacting result quality. As such, this change removes this restriction for simulators.

@speller26 speller26 changed the title Include all gates in simulator targets Include all gates in targets Feb 9, 2024
@speller26 speller26 changed the title Include all gates in targets Include all gates in simulator targets Feb 9, 2024
Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@speller26 speller26 merged commit bec3079 into main Feb 9, 2024
7 checks passed
@speller26 speller26 deleted the target branch February 9, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants