Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #51 | multiple registers #56

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Issue #51 | multiple registers #56

merged 2 commits into from
Jul 19, 2022

Conversation

Morcu
Copy link
Collaborator

@Morcu Morcu commented Jul 18, 2022

Summary

Fixex #51

Description

Registers mapping has been added

@Morcu Morcu requested a review from IceKhan13 July 18, 2022 20:58
IceKhan13
IceKhan13 requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@IceKhan13 IceKhan13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it!

Hmm, something is breaking.

AttributeError: 'QuantumCircuit' object has no attribute 'qubit_indices'

Probably qiskit has changed api for circuits. Try to upgrade to new version of qiskit in your dev env. We have released recently.

Morcu
Morcu commented Jul 19, 2022
View reviewed changes
Copy link
Collaborator Author

@Morcu Morcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

IceKhan13
IceKhan13 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Thank you David!

@IceKhan13 IceKhan13 merged commit 440911a into qiskit-community:main Jul 19, 2022
@IceKhan13 IceKhan13 deleted the issue-51/multiple-registers branch July 19, 2022 17:06
@IceKhan13 IceKhan13 added this to the Release 0.0.3 milestone Jul 19, 2022
@IceKhan13 IceKhan13 added bug Something isn't working enhancement New feature or request labels Jul 19, 2022
@IceKhan13 IceKhan13 mentioned this pull request Jul 19, 2022
Closed
@IceKhan13
Copy link
Member

It would be great to have more tests on that. Can be separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceKhan13 IceKhan13 IceKhan13 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Release 0.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Morcu @IceKhan13