Add ECR gate to mappers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
IceKhan13
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Sweet! Thank you for this addition @dexter2206 !
I think we need to fix linter (put commas at the end of the lists, dicts) and we are good to merge!
IceKhan13
requested changes
Aug 26, 2022
Ah, sorry, I forgot to run black. Fixed in 9fb5c2a :) |
IceKhan13
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds ECR gate to mappers in the
adapters.pymodule. Without this addition, running circuits containing the ECR gate through any of the AWS backends is impossible.Details and comments
No unit tests were added since there are already tests checking all the mappers. There are also no specific tests for other gates, so I wanted to stay consistent.