Add support for verbatim circuits and disable_qubit_rewiring #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceKhan13
reviewed
Aug 31, 2022
There was a problem hiding this comment.
@dexter2206 amazing work! All good on code side!
I only have comment on notebook. Last cell is not executed, so, we do not see result. And maybe we should catch error. By that we will show that error is expected.
What do you think?
|
I think we merge this and fix #45 and we will cut new release. |
Thanks! I will change the notebook as suggested tomorrow when Aspen is available. |
|
@dexter2206 hi there! any updates here? :) |
IceKhan13
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for verbatim boxes (only for whole circuits) and disabling qubit rewiring. The solution follows exactly the discussion in #58
Details and comments
Note that tests for the functionality have a
skipmark because they necessarily have to access external resources.