Rectified the display name of BracketLocalBackend #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this change @devilkiller-ag! Could you please add a unit test asserting this? |
|
Sure @kshitijc |
|
@kshitijc I added the test case |
|
@devilkiller-ag the tests are failing. Could you please fix? |
|
Sure, I am trying |
|
@kshitijc Is everything great now? |
|
Hi, @kshitijc , @IceKhan13, Is this PR ready to merge now? |
|
Sorry for the failure of previous styles check. I have rectified it and ran all the tests on local. It has been rated 10/10 now. |
kshitijc
approved these changes
May 30, 2023
There was a problem hiding this comment.
Perfect! Thank you for this contribution @devilkiller-ag! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I changed the value of
nameargument value passed to the super-class ofBraketLocalBackendto solve the issue #87. The bug was due the value'sv_simulator'passed in thenameargument instead of the backend name of called backend.