Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated append method with concat #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hurrifan1
Copy link

Replaced the deprecated and recently removed Dataframe.append() method with the recommended Pandas.concat(). Dataframe.append() has been deprecated for a while and was removed in the most recent Pandas 2.0.0 release. See Pandas issue here.

There was not an existing issue for this, let me know if I should make one first for tracking purposes.

Status

[ ] Under development
[X] Waiting for code review
[ ] Waiting for merge

Information

[ ] Contains breaking changes
[ ] Contains new API(s)
[ ] Contains documentation
[ ] Contains test
[ ] Contains examples

To-do list

No todos

Replaced the deprecated and rcently removed `Dataframe.append()` method with the recommended `Pandas.concat()`. See Pandas issue here -> pandas-dev/pandas#35407
Missed the actual change lol
@qlikossbuild
Copy link

Hi, and thanks for contributing!

Note: If you are part of Qlik:
follow the process outlined on the internal developer portal instead.
Reach out to open-source@qlik.com if you do not have access to that developer portal.


Before we can handle your pull request we need you to sign our contributor license agreement.
This is a one-time process and enables you to contribute without hassle to any of the qlik-oss repositories in the future.

And it only takes a few minutes! Here are some useful links to get you started:

Having troubles? Feel free to reach out to us either here or on Slack!

Note: Once the CLA is sorted, you should rebase/touch this pull request to trigger an update of this CLA status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants