Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Keyboard Settings keycodes #1204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noroadsleft
Copy link
Member

Description

Adds the following keycodes to QMK Configurator:

  • CL_TOGG: Toggle Caps Lock and Left Control swap
  • GUI_TOG: Toggles the status of the GUI keys
  • NK_TOGG: Toggle N-key rollover
  • AG_TOGG: Toggle Alt and GUI swap on both sides
  • CG_TOGG: Toggle Control and GUI swap on both sides
  • EC_SWAP: Swap Caps Lock and Escape
  • EC_TOGG: Toggle Caps Lock and Escape swap
  • EC_NORM: Unswap Caps Lock and Escape
  • EH_LEFT: Set the master half of a split keyboard as the left hand (for EE_HANDS)
  • EH_RGHT: Set the master half of a split keyboard as the right hand (for EE_HANDS)

- `CL_TOGG`: Toggle Caps Lock and Left Control swap
- `GUI_TOG`: Toggles the status of the GUI keys
- `NK_TOGG`: Toggle N-key rollover
- `AG_TOGG`: Toggle Alt and GUI swap on both sides
- `CG_TOGG`: Toggle Control and GUI swap on both sides
- `EC_SWAP`: Swap Caps Lock and Escape
- `EC_TOGG`: Toggle Caps Lock and Escape swap
- `EC_NORM`: Unswap Caps Lock and Escape
- `EH_LEFT`: Set the master half of a split keyboard as the left hand (for EE_HANDS)
- `EH_RGHT`: Set the master half of a split keyboard as the right hand (for EE_HANDS)
@noroadsleft
Copy link
Member Author

noroadsleft commented Nov 9, 2022

Went for an Enable-Toggle-Disable layout, by rows:

image

Comment on lines +105 to +113
{
width: 3000
},
{
width: 3000
},
{
width: 1500
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I feel about this bit...

Copy link
Collaborator

@yanfali yanfali Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could create an alias to an object like so:

const blank3000Row = { width: 3000 };

and then use it like so:

...blank3000Row

or without the spread operator depending on how you surround it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue I'm having with this is that I need a space that's 7.5 key units, but there isn't a spacer class in the CSS for one.

I could add one of course, but I don't think that's a scalable solution.

name: 'Swap Caps/Esc',
code: 'EC_SWAP',
title: 'Swap Caps Lock and Escape',
width: 1500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're using the same width in a lot of places, you can replace this with a constant.

@yanfali
Copy link
Collaborator

yanfali commented Oct 28, 2023

@noroadsleft merge if you're happy with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants