Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Project housekeeping #288

Merged
merged 6 commits into from
Jul 24, 2021
Merged

[Windows] Project housekeeping #288

merged 6 commits into from
Jul 24, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 23, 2021 •
edited
Loading

Description

  • Removed unused packages MetroFramework, IntelHexFormatReader, NLog, and RJCP.SerialPortStream
  • Removed unused usings
  • Tidied up .csproj (lots of empty PropertyGroups, removed ClickOnce stuff)
  • Bumped .NET Framework version to 4.8
  • Switched from third-party System.IO.Compression library to official Microsoft one
  • Updated NuGet packages
  • Upped warning level, obeyed Visual Studio's new complaints

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team July 23, 2021 10:42
@fauxpark fauxpark merged commit c8de706 into qmk:master Jul 24, 2021
@fauxpark fauxpark deleted the windows-housekeeping branch July 24, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc