This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
ShellStream: Add ReadAsync implementation #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encourage asynchronously executing a command on the device using
AdbClient.ExecuteRemoteCommandAsync
.However, this will then use a
ShellStream
which only supports synchronous reading data off the stream.Additionally, to support cancellation,
AdbClient.ExecuteRemoteCommandAsync
will invokecancellationToken.Register(() => socket.Dispose())
.However, on Unix, calling
socket.Dispose
will not unblock synchronous calls for current versions of .NET Core. (This is fixed in .NET 5.0). dotnet/corefx#38804 has the details.As a result, cancellation of
ExecuteRemoteCommandAsync
methods is effectively impossible.This PR implements aynchronous methods in
ShellStream
, making the scenario work.