Bump maven-compiler-plugin to 3.12.1 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Thanks @gastaldi!
LGTM. We might want to wait for maven-compiler-plugin 3.12.1 tough; I don't know how bad the bug affecting Quarkus is and whether it can affect applications as well.
See quarkusio/quarkus#37842 , https://issues.apache.org/jira/browse/MCOMPILER-567
gastaldi
changed the title
gastaldi
force-pushed
the
update_compiler_plugin
branch
from
fe0cfaf
to
7df828d
Compare
gsmet
approved these changes
Dec 20, 2023
|
Actually, it didn't work because of: openrewrite/rewrite#3842 . I will push a workaround while waiting for the fix to end up upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recipe documentation in https://docs.openrewrite.org/recipes/maven/upgradepluginversion