Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even if feature about serialization (from GraalVM 21.0 ) is proposed, small change could make it work even now #15039

Closed
JiriOndrusek opened this issue Feb 12, 2021 · 2 comments · Fixed by #15043
Labels
Milestone

Comments

@JiriOndrusek
Copy link
Contributor

Description
There is an issue about Better DevExp for serialization feature support as of GraalVM 2 (#14530)

But it is possible to make serialization work only by removing substitution, which cuts off serialization - see 214e05c

Implementation ideas
I've tested camel-quarkus nitrite extension, which uses java serialization.

With provided serialization mapping (JiriOndrusek/camel-quarkus@04134ef#diff-e008186a29d7dc393c8bc2c05a5303d14d3f13050f7f48dc08b27d50edaf68f9R1) and removed substitution https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/graal/JavaIOSubstitutions.java, serialization works. (my test could be used as reproducer, use this commit JiriOndrusek/camel-quarkus@04134ef and execute by mvn clean verify -Pnative -f integration-tests/nitrite)

I'd like to suggest to remove substitution https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/graal/JavaIOSubstitutions.java. (if it makes sense)

@JiriOndrusek JiriOndrusek added the kind/enhancement New feature or request label Feb 12, 2021
@gsmet
Copy link
Member

gsmet commented Feb 12, 2021

@JiriOndrusek if CI is OK with it, I'm OK too.

@JiriOndrusek
Copy link
Contributor Author

@gsmet Sorry, I didn't understand correctly. I'll try to create PR and see whether CI is ok. I've tested only my usecase.

JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Feb 12, 2021
geoand pushed a commit that referenced this issue Feb 15, 2021
geoand added a commit that referenced this issue Feb 15, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 15, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.0.Final Feb 16, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Feb 16, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Feb 17, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Feb 24, 2021
This reverts commit 66a6e9a.

(cherry picked from commit 96d3a45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants