Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error if annotation processing directories do not exist #43169

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

ChristianKernDev
Copy link

@ChristianKernDev ChristianKernDev commented Sep 10, 2024

Fix #42908

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 10, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)
  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@ChristianKernDev ChristianKernDev changed the title Fixes #42908 Fixes error if annotation processing directories do not exist Sep 10, 2024
@gsmet gsmet requested a review from FroMage September 10, 2024 12:10
@quarkus-bot

This comment has been minimized.

private void ensureDirectories(Iterable<File> directories){
for (File processorPath : directories) {
if (!processorPath.exists()) {
processorPath.mkdirs();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check for the return of mkdirs? It returns false when it fails, in which case you can throw a RuntimeException explaning the problem.

@FroMage
Copy link
Member

FroMage commented Sep 10, 2024

Also, it looks like you need to run the formatter, you can do it with mvn -f core/deployment process-sources

@FroMage
Copy link
Member

FroMage commented Sep 10, 2024

Otherwise, looks great :) Thanks

@ChristianKernDev
Copy link
Author

Added the exception. I can't execute the formatter, because of the folling error: org.gradle:gradle-tooling-api:jar:8.1.1 was not found

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@FroMage
Copy link
Member

FroMage commented Sep 10, 2024

Added the exception. I can't execute the formatter, because of the folling error: org.gradle:gradle-tooling-api:jar:8.1.1 was not found

I think you have to install Gradle, you can do it with "sdk install gradle"

@FroMage
Copy link
Member

FroMage commented Sep 10, 2024

I've tried to run the formatter locally and it didn't find anything to format, I'm going to assume your second commit fixed the issue :)

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 10, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dd8ae2c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 26e5053 into quarkusio:main Sep 10, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 10, 2024
@gsmet
Copy link
Member

gsmet commented Sep 10, 2024

Thanks!

@gsmet gsmet modified the milestones: 3.16 - main, 3.14.3 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Cannot initialize file manager
3 participants