-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes error if annotation processing directories do not exist #43169
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
This comment has been minimized.
This comment has been minimized.
private void ensureDirectories(Iterable<File> directories){ | ||
for (File processorPath : directories) { | ||
if (!processorPath.exists()) { | ||
processorPath.mkdirs(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a check for the return of mkdirs
? It returns false
when it fails, in which case you can throw a RuntimeException
explaning the problem.
Also, it looks like you need to run the formatter, you can do it with |
Otherwise, looks great :) Thanks |
Added the exception. I can't execute the formatter, because of the folling error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I think you have to install Gradle, you can do it with "sdk install gradle" |
I've tried to run the formatter locally and it didn't find anything to format, I'm going to assume your second commit fixed the issue :) |
Status for workflow
|
Thanks! |
Fix #42908