Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROJQUAY-7424: Correct the quay_storage volume name in uninstalling task #154

Closed
wants to merge 1 commit into from

Conversation

bysnupy
Copy link

@bysnupy bysnupy commented Jun 26, 2024

  • Description: The "quay_storage" volume name in the uninstall task should be "quay-storage" for deleting the volume directory during uninstalling. Because the quay volume creates as "quay-storage" by default when installing. The volume name should be matched. Refer the following codes which show us the place holder of "quay_storage=%s" is "quay-storage" by default as well.
  • References:
    • installCmd.Flags().StringVarP(&quayStorage, "quayStorage", "", "quay-storage", "The folder where quay persistent storage data is saved. This defaults to a Podman named volume 'quay-storage'. Root is required to uninstall.")

The "quay_storage" volume name in the uninstall task should be "quay-storage" for deleting the volume directory during uninstalling. Because the quay volume creates as "quay-storage" by default when installing. The volume name should be matched.
@bysnupy bysnupy changed the title Correct the quay_storage volume name in uninstalling task PROJQUAY-7424: Correct the quay_storage volume name in uninstalling task Jul 2, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bysnupy
Copy link
Author

bysnupy commented Aug 13, 2024

This fix has been applied through #152
So I close this ticket.

@bysnupy bysnupy closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Development

Successfully merging this pull request may close these issues.

2 participants