Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quayapp(deploymenttemplate): mounting optional postgres certs (PROJQUAY-2417) #854

Merged
merged 22 commits into from
Sep 17, 2024
Merged

quayapp(deploymenttemplate): mounting optional postgres certs (PROJQUAY-2417) #854

merged 22 commits into from
Sep 17, 2024

Conversation

michaelalang
Copy link
Contributor

fixed typo in configmap which prevents the deployment to be scheduled

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2023

Hi @michaelalang. Thanks for your PR.

I'm waiting for a quay member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelalang and others added 15 commits May 31, 2024 10:18
@michaelalang @HammerMeetNail
adding Postgres client certificate secret,mount overlay
ec6adda
@michaelalang @HammerMeetNail
fixed missing secrets mount
be722c1
@michaelalang @HammerMeetNail
fixed Unit for emptyDir size
29fa2cf
@michaelalang
Merge branch 'quay:master' into master
5cb27d3
@michaelalang
Resolve merge conflict
2e0b323
@michaelalang
chore: rename upstream operator to project-quay (quay#928)
e21d1cf 
* Revert "chore: fix yq script"

This reverts commit ce015df.

* Revert "chore: bundle.package.v1 should match CSV name, i.e. be quay-operator (quay#920)"

This reverts commit 012186d.

* chore: rename upstream operator to project-quay
@michaelalang
chore: rename upstream operator back to quay-operator (quay#930)
839fb19
@jonathankingfc @michaelalang
pgupgrade: Fix clairpgupgrade path (PROJQUAY-7392)
3282d22 
- Fix kustomize path for clairpgupgrade when clair is managed/unmanaged
@jonathankingfc @michaelalang
pgupgrade: Update pgupgrade path (PROJQUAY-7329)
b765a54 
- Remove base from pgupgrade path to ensure that the file location is parsed properly by kustomize package
@dependabot @michaelalang
build(deps): bump github.com/jackc/pgx/v4 from 4.11.0 to 4.18.2
afad5c9 
Bumps [github.com/jackc/pgx/v4](https://github.com/jackc/pgx) from 4.11.0 to 4.18.2.
- [Changelog](https://github.com/jackc/pgx/blob/v4.18.2/CHANGELOG.md)
- [Commits](jackc/pgx@v4.11.0...v4.18.2)

---
updated-dependencies:
- dependency-name: github.com/jackc/pgx/v4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@syed @michaelalang
Add docs for env variable upgrades
718d8df
@michaelalang
Merge branch 'quay:master' into master
4324eb7
@michaelalang
Revert "adding Postgres client certificate secret,mount overlay"
f88e071 
This reverts commit ec6adda.
@michaelalang
Revert "fixed missing secrets mount"
9285ad5 
This reverts commit be722c1.
@michaelalang
Revert "fixed Unit for emptyDir size"
3eb4c30 
This reverts commit 29fa2cf.
bcaton85
bcaton85 requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@bcaton85 bcaton85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a couple of changes and we're good to go. Can you also rebase? This PR also has to be merged for this to work.

kustomize/base/quay.deployment.yaml Outdated
optional: true
- secret:
name: postgresql-client-certs
optional: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to use the following indentation where name and optional appear under secret. I wouldn't copy from here since Github formatting seems to be odd.

- name: postgres-certs
  projected:
    sources:
      - secret:
          name: postgresql-ca
          optional: true
      - secret:
          name: postgresql-client-certs
          optional: true

kustomize/base/quay.deployment.yaml Outdated
- name: postgres-certs
mountPath: /run/secrets/postgres
- name: postgres-certs-store
mountPath: /.postgres
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be /.postgresql to match what's defined in quay-entrypoint

kustomize/base/quay.deployment.yaml Outdated
@@ -129,3 +141,7 @@ spec:
- name: extra-ca-certs
readOnly: true
mountPath: /conf/stack/extra_ca_certs
- name: postgres-certs
mountPath: /run/secrets/postgres
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be /run/secrets/postgresql to match what's defined in quay-entrypoint

kustomize/base/quay.deployment.yaml Show resolved Hide resolved
@bcaton85
Copy link
Contributor

/ok-to-test

@bcaton85 bcaton85 changed the title quay-app(deployment-template): fixed typo in configmap (PROJQUAY-2417) quayapp(deploymenttemplate): fixed typo in configmap (PROJQUAY-2417) Sep 17, 2024
@bcaton85 bcaton85 changed the title quayapp(deploymenttemplate): fixed typo in configmap (PROJQUAY-2417) quayapp(deploymenttemplate): mounting optional postgres certs (PROJQUAY-2417) Sep 17, 2024
@bcaton85 bcaton85 merged commit 8b6bf40 into quay:master Sep 17, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcaton85 bcaton85 bcaton85 approved these changes

@jonathankingfc jonathankingfc Awaiting requested review from jonathankingfc

Assignees
No one assigned
Labels
ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelalang @bcaton85 @jonathankingfc @syed