Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConstructionBase.setproperties instead of hand-coding setconfig #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Oct 12, 2019

I suggest using ConstructionBase.setproperties instead of the manually coded setconfig.

@codecov-io
Copy link

Codecov Report

Merging #35 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   80.76%   80.58%   -0.19%     
==========================================
  Files           2        2              
  Lines         104      103       -1     
==========================================
- Hits           84       83       -1     
  Misses         20       20
Impacted Files Coverage Δ
src/ElectronDisplay.jl 77.01% <100%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9d797...cbe022d. Read the comment docs.

@davidanthoff
Copy link
Member

I like this, but maybe we can wait until ConstructionBase.jl has hit 1.0.0 and follows normal semver semantics? Maybe that is something that can already happen over there?

@tkf
Copy link
Contributor Author

tkf commented Oct 12, 2019

I think that's a reasonable concern. I brought this up in JuliaObjects/ConstructionBase.jl#6 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants