Skip to content

Commit

Permalink
feat(modal): discovery-148 pf4 modal wrapper (#110)
Browse files Browse the repository at this point in the history
* locales, modal default string
* modal, consistent pf4 wrapper, allow backdrop disable
  • Loading branch information
cdcabrera committed Sep 20, 2022
1 parent a62c2be commit 8bc5c28
Show file tree
Hide file tree
Showing 7 changed files with 643 additions and 0 deletions.
3 changes: 3 additions & 0 deletions public/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"server-version": "Server Version",
"ui-version": "UI Version",
"username": "Username"
},
"modal": {
"aria-label-default": "Application modal"
}
}
9 changes: 9 additions & 0 deletions src/components/i18n/__tests__/__snapshots__/i18n.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ Array [
},
],
},
Object {
"file": "./src/components/modal/modal.js",
"keys": Array [
Object {
"key": "modal.aria-label-default",
"match": "t('modal.aria-label-default')",
},
],
},
]
`;

Expand Down
Loading

0 comments on commit 8bc5c28

Please sign in to comment.