refactor(credentials): discovery-148 pf4 empty-state #116

cdcabrera · 2022-07-07T20:55:58Z

What's included

Code Refactoring

credentials discovery-148 pf4 empty-state (8e583be)

Notes

updated the Authentication component to align with Credentials with its locale strings, and error display . This update will allow code reuse with the empty-state updates to Sources and Scans

How to test

Local run check

update the NPM packages with $ yarn
$ yarn start:stage
navigate to the credentials view, having zero credentials and the initial welcome message should display
next add some credentials then filter them so NO credentials displays, and confirm the empty state filter with magnifying glass displays

recreating the error we handled by modifying the Redux state layer... open the ./src/components/credentials/credentials.js file and add the two lines for , error: true, errorMessage: 'Lorem ipsum'

   const mapStateToProps = state => ({
      ...state.credentials.view,
      viewOptions: state.viewOptions[reduxTypes.view.CREDENTIALS_VIEW],
      update: state.credentials.update,
      error: true,
      errorMessage: 'Lorem ipsum'
   });

Example

BEFORE

AFTER

Aligned login error alert with Credentials, and future Sources, Scans error alert

(it moved down)

Updates issue/story

DISCOVERY-148

#99

codecov-commenter · 2022-07-08T00:03:38Z

Codecov Report

❗ No coverage uploaded for pull request base (dev@e66e54d). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #116   +/-   ##
======================================
  Coverage       ?   72.11%           
======================================
  Files          ?       95           
  Lines          ?     3066           
  Branches       ?      835           
======================================
  Hits           ?     2211           
  Misses         ?      756           
  Partials       ?       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66e54d...4bc426b. Read the comment docs.

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

bclarhk

Silly Dropdown button is part of a different task. LGTM

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

author CD Cabrera <ccabrera@redhat.com> 1654528943 -0400 committer jenny-s51 <jshandel@redhat.com> 1659366125 -0400 fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) refactor(services): discovery-8 minor config restructure (quipucords#82) * service config, allow opts, fallback xhr timeout * api calls, config wrapper function, named imports refactor(redux): discovery-8 middleware, hooks, restructure (quipucords#82) * helpers, aggregatedError func for redux hooks * redux actions, named exports * redux hooks, useReactRedux * redux middleware, middleware export, multi-actions * store, move middleware, named export fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) refactor(authentication): discovery-148 pf4 alert, locale (quipucords#112) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(refreshTimeButton): discovery-149 pf4 button, icon (quipucords#114) refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state refactor(toastNotificationsList): discovery-148, pf4 alert (quipucords#115) * build, dotenv toast timeout * components, adjust alertType to alert variant * helpers, expose toast timeout * toastNotificationsList, pf4 alert, alertGroup * toastNotificationsReducer, adjust pause, resume fix(testing): expand toastNotificationsList snapshots (quipucords#115) refactor(sources): discovery-148 pf4 empty-state (quipucords#120) * locale, add empty-state strings * sources, pf4 empty-state refactor(creds,sources,scans): discovery-149 emptyState grid (quipucords#121) * credentials, sources, scansEmptyState, remove grid fix(i18n): discovery-8 partial context into keys (quipucords#124) feat(wizard): discovery-153 pf4 wizard wrapper (quipucords#124) * confirmationModal, pass isContentOnly * modal, add isContentOnly, removes padding * wizard, consistent pf4 wrapper, allow modal sizing refactor(addSourceWizard): discovery-153, pf4 wizard (quipucords#124) * locale, wizard form strings * addSourceWizard, Constants, restructure steps * addSourceWizardStepThree, add empty-state * styling, restructure pf3 styling wizard form refactor(scanHostList): discovery-148, pf4 empty-state (quipucords#125) refactor(pagination): wip refactor(pagination): use PF4 component refactor(pagination): update snapshots refactor(pagination): update test refactor(pagination): update test refactor(creds,sources,scans): discovery-149 pf4 grid, list (quipucords#126) * credentialsListItem, grid to list, tooltip * credentials, removed grid * scanHostList, grid to list * scanSourceList nested list with icon * sourceCredentialsList, list with icon refactor(dropdownSelect): discovery-152 pf4 select, dropdown (quipucords#127) * addSourceWizardStepTwo, options, pf4 select list * createCredentialDialog, pf4 select list * dropdownSelect, use Curiosity pf4 select wrapper * locale, option strings refactor(dropdownSelect): discovery-152 pf4 dropdown (quipucords#130) feat(addCredentialType): discovery-152 button selector (quipucords#130) refactor(credentials): discovery-152, pf4 dropdown (quipucords#130) * credentials, pf4 button, addCredentialType * credentialsEmptyState, addCredentialType * locale, cred strings

author CD Cabrera <ccabrera@redhat.com> 1654528943 -0400 committer jenny-s51 <jshandel@redhat.com> 1659366125 -0400 fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) refactor(services): discovery-8 minor config restructure (quipucords#82) * service config, allow opts, fallback xhr timeout * api calls, config wrapper function, named imports refactor(redux): discovery-8 middleware, hooks, restructure (quipucords#82) * helpers, aggregatedError func for redux hooks * redux actions, named exports * redux hooks, useReactRedux * redux middleware, middleware export, multi-actions * store, move middleware, named export fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) refactor(authentication): discovery-148 pf4 alert, locale (quipucords#112) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(refreshTimeButton): discovery-149 pf4 button, icon (quipucords#114) refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state refactor(toastNotificationsList): discovery-148, pf4 alert (quipucords#115) * build, dotenv toast timeout * components, adjust alertType to alert variant * helpers, expose toast timeout * toastNotificationsList, pf4 alert, alertGroup * toastNotificationsReducer, adjust pause, resume fix(testing): expand toastNotificationsList snapshots (quipucords#115) refactor(sources): discovery-148 pf4 empty-state (quipucords#120) * locale, add empty-state strings * sources, pf4 empty-state refactor(creds,sources,scans): discovery-149 emptyState grid (quipucords#121) * credentials, sources, scansEmptyState, remove grid fix(i18n): discovery-8 partial context into keys (quipucords#124) feat(wizard): discovery-153 pf4 wizard wrapper (quipucords#124) * confirmationModal, pass isContentOnly * modal, add isContentOnly, removes padding * wizard, consistent pf4 wrapper, allow modal sizing refactor(addSourceWizard): discovery-153, pf4 wizard (quipucords#124) * locale, wizard form strings * addSourceWizard, Constants, restructure steps * addSourceWizardStepThree, add empty-state * styling, restructure pf3 styling wizard form refactor(scanHostList): discovery-148, pf4 empty-state (quipucords#125) refactor(pagination): wip refactor(pagination): use PF4 component refactor(pagination): update snapshots refactor(pagination): update test refactor(pagination): update test refactor(creds,sources,scans): discovery-149 pf4 grid, list (quipucords#126) * credentialsListItem, grid to list, tooltip * credentials, removed grid * scanHostList, grid to list * scanSourceList nested list with icon * sourceCredentialsList, list with icon refactor(dropdownSelect): discovery-152 pf4 select, dropdown (quipucords#127) * addSourceWizardStepTwo, options, pf4 select list * createCredentialDialog, pf4 select list * dropdownSelect, use Curiosity pf4 select wrapper * locale, option strings refactor(dropdownSelect): discovery-152 pf4 dropdown (quipucords#130) feat(addCredentialType): discovery-152 button selector (quipucords#130) refactor(credentials): discovery-152, pf4 dropdown (quipucords#130) * credentials, pf4 button, addCredentialType * credentialsEmptyState, addCredentialType * locale, cred strings refactor(pagination): update snapshots

fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) refactor(services): discovery-8 minor config restructure (quipucords#82) * service config, allow opts, fallback xhr timeout * api calls, config wrapper function, named imports refactor(redux): discovery-8 middleware, hooks, restructure (quipucords#82) * helpers, aggregatedError func for redux hooks * redux actions, named exports * redux hooks, useReactRedux * redux middleware, middleware export, multi-actions * store, move middleware, named export fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) refactor(authentication): discovery-148 pf4 alert, locale (quipucords#112) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(refreshTimeButton): discovery-149 pf4 button, icon (quipucords#114) refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state refactor(toastNotificationsList): discovery-148, pf4 alert (quipucords#115) * build, dotenv toast timeout * components, adjust alertType to alert variant * helpers, expose toast timeout * toastNotificationsList, pf4 alert, alertGroup * toastNotificationsReducer, adjust pause, resume fix(testing): expand toastNotificationsList snapshots (quipucords#115) refactor(sources): discovery-148 pf4 empty-state (quipucords#120) * locale, add empty-state strings * sources, pf4 empty-state refactor(creds,sources,scans): discovery-149 emptyState grid (quipucords#121) * credentials, sources, scansEmptyState, remove grid fix(i18n): discovery-8 partial context into keys (quipucords#124) feat(wizard): discovery-153 pf4 wizard wrapper (quipucords#124) * confirmationModal, pass isContentOnly * modal, add isContentOnly, removes padding * wizard, consistent pf4 wrapper, allow modal sizing refactor(addSourceWizard): discovery-153, pf4 wizard (quipucords#124) * locale, wizard form strings * addSourceWizard, Constants, restructure steps * addSourceWizardStepThree, add empty-state * styling, restructure pf3 styling wizard form refactor(scanHostList): discovery-148, pf4 empty-state (quipucords#125) refactor(pagination): wip refactor(pagination): use PF4 component refactor(pagination): update snapshots refactor(pagination): update test refactor(pagination): update test refactor(creds,sources,scans): discovery-149 pf4 grid, list (quipucords#126) * credentialsListItem, grid to list, tooltip * credentials, removed grid * scanHostList, grid to list * scanSourceList nested list with icon * sourceCredentialsList, list with icon refactor(dropdownSelect): discovery-152 pf4 select, dropdown (quipucords#127) * addSourceWizardStepTwo, options, pf4 select list * createCredentialDialog, pf4 select list * dropdownSelect, use Curiosity pf4 select wrapper * locale, option strings refactor(dropdownSelect): discovery-152 pf4 dropdown (quipucords#130) feat(addCredentialType): discovery-152 button selector (quipucords#130) refactor(credentials): discovery-152, pf4 dropdown (quipucords#130) * credentials, pf4 button, addCredentialType * credentialsEmptyState, addCredentialType * locale, cred strings refactor(pagination): update snapshots

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

cdcabrera added the pf4 Tracking for pf4 refactors label Jul 7, 2022

cdcabrera force-pushed the dis-148-emptystate branch from 8e583be to da7c3fd Compare July 8, 2022 00:00

refactor(credentials): discovery-148 pf4 empty-state

4bc426b

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

cdcabrera force-pushed the dis-148-emptystate branch from da7c3fd to 4bc426b Compare July 8, 2022 00:54

cdcabrera requested review from bclarhk and ruda July 8, 2022 01:08

cdcabrera marked this pull request as ready for review July 8, 2022 01:08

bclarhk approved these changes Jul 8, 2022

View reviewed changes

cdcabrera merged commit 8c470e2 into quipucords:dev Jul 8, 2022

cdcabrera added a commit that referenced this pull request Jul 12, 2022

refactor(credentials): discovery-148 pf4 empty-state (#116)

155a292

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

cdcabrera added a commit that referenced this pull request Aug 12, 2022

refactor(credentials): discovery-148 pf4 empty-state (#116)

a64bada

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

cdcabrera added a commit that referenced this pull request Sep 7, 2022

refactor(credentials): discovery-148 pf4 empty-state (#116)

ce089f7

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

cdcabrera added a commit that referenced this pull request Sep 8, 2022

refactor(credentials): discovery-148 pf4 empty-state (#116)

7bca8e8

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

cdcabrera added a commit that referenced this pull request Sep 20, 2022

refactor(credentials): discovery-148 pf4 empty-state (#116)

e2a17f2

* locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(credentials): discovery-148 pf4 empty-state #116

refactor(credentials): discovery-148 pf4 empty-state #116

cdcabrera commented Jul 7, 2022 •

edited

Loading

codecov-commenter commented Jul 8, 2022 •

edited

Loading

bclarhk left a comment

refactor(credentials): discovery-148 pf4 empty-state #116

refactor(credentials): discovery-148 pf4 empty-state #116

Conversation

cdcabrera commented Jul 7, 2022 • edited Loading

What's included

Code Refactoring

Notes

How to test

Local run check

Example

BEFORE

AFTER

Aligned login error alert with Credentials, and future Sources, Scans error alert

Updates issue/story

codecov-commenter commented Jul 8, 2022 • edited Loading

Codecov Report

bclarhk left a comment

Choose a reason for hiding this comment

cdcabrera commented Jul 7, 2022 •

edited

Loading

codecov-commenter commented Jul 8, 2022 •

edited

Loading