Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(buttons): convert buttons in scans and credentials list views #142

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Aug 15, 2022

What's included

...
Converts PF3 buttons to PF4 buttons in list view of Scans and Credentials screens.

This includes the icons on the right of every list item, and the "Merge Reports" button on the Scans screen.

Notes

The changes in this PR are aligned with the code and feedback in #136

Example

...

Before

Screen Shot 2022-08-15 at 2 07 09 PM

Screen Shot 2022-08-15 at 2 07 24 PM

Screen Shot 2022-08-15 at 2 07 50 PM

Screen Shot 2022-08-15 at 11 43 26 AM

After

Screen Shot 2022-08-19 at 3 41 06 PM

Screen Shot 2022-08-15 at 2 03 55 PM

Screen Shot 2022-08-15 at 2 04 43 PM

Screen Shot 2022-08-15 at 2 06 07 PM

Screen Shot 2022-08-15 at 2 06 38 PM

Updates issue/story

DISCOVERY-149
#134

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@a104f02). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e17d910 differs from pull request most recent head b5c4c91. Consider uploading reports for the commit b5c4c91 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #142   +/-   ##
======================================
  Coverage       ?   75.97%           
======================================
  Files          ?      101           
  Lines          ?     3292           
  Branches       ?      920           
======================================
  Hits           ?     2501           
  Misses         ?      701           
  Partials       ?       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a104f02...b5c4c91. Read the comment docs.

@jenny-s51 jenny-s51 changed the title refactor(buttons): convert buttons in scans and sources list views refactor(buttons): convert buttons in scans and credentials list views Aug 17, 2022
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check with Ben on the button but otherwise, lgtm!

src/components/scans/scans.js Outdated Show resolved Hide resolved
@cdcabrera cdcabrera requested review from bclarhk and ruda August 17, 2022 17:54
@cdcabrera cdcabrera added the pf4 Tracking for pf4 refactors label Aug 17, 2022
@cdcabrera cdcabrera mentioned this pull request Aug 17, 2022
3 tasks
Copy link

@bclarhk bclarhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure why the merge reports is/was a secondary button. It's the only real action on the page. Let's make it the primary button.

@cdcabrera cdcabrera merged commit ef83994 into quipucords:dev Aug 19, 2022
Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reviews and feedback @cdcabrera @bclarhk !

I've switched the button to use the primary variant, and have uploaded a screenshot with the updated appearance of the "merge reports" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pf4 Tracking for pf4 refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants