refactor(button,icon,spinner): discovery-149 pf4 replacements

[cdcabrera]

What's included

• refactor(button,icon,spinner): discovery-149 pf4 replacements

Notes

• clean up for the last remaining button, icon, and spinners outside of pageLayout
• starts to align modal dialogs across
  • add source wizard
  • create scan dialog
  • merge reports dialog
• these updates highlight the inconsistency in our modal/dialog implementations.
  • add source wizard
    • shows both the x closing button and close button while pending
  • create scan dialog
    • shows the x closing button while pending
  • merge reports dialog
    • shows the closing button while pending
• the remaining modal/dialog has variations in behavior that need to be brought into alignment
  • create credential dialog
    • does not have a pending message,
    • shuts down immediately after submission
    • uses its own internal form state

How to test

Coverage and basic unit test check

1. update the NPM packages with $ yarn
2. $ yarn test
3. confirm tests come back clean

Local run check

1. update the NPM packages with $ yarn
2. $ yarn start:stage
3. confirm that
   1. the download link for compound expanded scans displays, and is downloadable
   2. confirm the icon displays in the confirmation dialog associated with merging reports/scans

Example

before

after

Updates issue/story

DISCOVERY-149
closes #134
closes #97

[codecov-commenter]

Codecov Report

Merging #165 (6cecb23) into dev (5e9371e) will increase coverage by 0.02%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##              dev     #165      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.02%     
==========================================
  Files         108      108              
  Lines        3464     3468       +4     
  Branches     1133     1135       +2     
==========================================
+ Hits         2782     2786       +4     
  Misses        601      601              
  Partials       81       81              

Impacted Files	Coverage Δ
...rc/components/createScanDialog/createScanDialog.js	57.00% <ø> (ø)
...omponents/mergeReportsDialog/mergeReportsDialog.js	65.67% <66.66%> (ø)
src/components/contextIcon/contextIcon.js	88.13% <100.00%> (+0.86%)	⬆️
src/components/pageLayout/pageLayout.js	80.76% <100.00%> (ø)
src/components/scans/scanDownload.js	50.00% <100.00%> (ø)
src/components/scans/scanJobsList.js	64.86% <100.00%> (ø)
src/components/tooltip/tooltip.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9371e...6cecb23. Read the comment docs.

[bclarhk]

Looks good. We'll fix the inconsistencies later.