Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(credentials): ds-391 SSH key placeholder text #443

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(credentials): ds-391 SSH key placeholder text #443

merged 1 commit into from
Sep 12, 2024

Conversation

nicolearagao
Copy link
Member

fix(credentials): ds-391 SSH key placeholder text

Notes

  • Enhance placeholder of SSH key field and add helper text to clarify things for user

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start
  3. confirm connections display as intended

Example

...
Screenshot from 2024-09-12 11-27-59

Updates issue/story

DISCOVERY-391

cdcabrera
cdcabrera approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just string updates, lgtm!

@nicolearagao nicolearagao merged commit 6978a70 into quipucords:main Sep 12, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdcabrera cdcabrera cdcabrera approved these changes

@mirekdlugosz mirekdlugosz Awaiting requested review from mirekdlugosz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolearagao @cdcabrera