Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(addSourceModal): ds-767 lint, test updates #446

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • test(addSourceModal): ds-767 lint, test updates

Notes

  • minor component clean up
  • implementation of a getCredentialsApi get wrapper instead of a direct XHR call
  • basic unit testing added

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back as expected

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start:stage
  3. confirm adding a source still behaves as intended

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm output comes back passing

Example

...

Updates issue/story

@cdcabrera cdcabrera force-pushed the ds-767-addSourceModal branch 2 times, most recently from 29ec948 to a14e0a2 Compare September 13, 2024 14:45
@nicolearagao nicolearagao marked this pull request as ready for review September 17, 2024 20:20
Copy link
Member

@nicolearagao nicolearagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicolearagao nicolearagao merged commit cc533bc into quipucords:main Sep 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants