Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(cred,source,scan): ds-438 popup style fix #454

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

nicolearagao
Copy link
Member

@nicolearagao nicolearagao commented Sep 18, 2024

Unify popup style across Sources, Creds, Scans
Remove cancel button

Notes

  • fix to "[Mirek] On “Sources” list. I can click a number in “Credentials” column and that will open new popup window. That window has both “close” button and “cancel” link (all lowercase). “close” is with red background, as if that was destructive action. That popup should probably use the same style as “Last connected” popup - it is purely informative.
    The same applies to popup that appears on “Credentials” page, when clicking number in “Sources” column
    It also appears on “Scans” page, when clicking number in “Sources” column"

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start
  3. confirm connections display as intended

Example

Screenshot from 2024-09-18 13-44-29
Screenshot from 2024-09-18 13-42-12
Screenshot from 2024-09-18 13-42-03

Updates issue/story

DISCOVERY-438

Relates to JIRA: DISCOVERY-438
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technical implementation lgtm!

@nicolearagao nicolearagao merged commit 1db100d into quipucords:main Sep 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants