Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 20 requires loader parameter again #5910

Closed
quisquous opened this issue Nov 7, 2023 · 2 comments · Fixed by #5990
Closed

Node 20 requires loader parameter again #5910

quisquous opened this issue Nov 7, 2023 · 2 comments · Fixed by #5990
Labels
bug help wanted

Comments

@quisquous
Copy link
Owner

See conversation thread here: #5859 (comment)

With Node 18 this works, but with Node 20 it seems to revert to previous behavior.
quisquous added a commit that referenced this issue Dec 6, 2023
@quisquous
build: temporarily limit node version
5273770 
Do this until a better solution for #5910 exists.
@quisquous quisquous mentioned this issue Dec 6, 2023
Merged
@quisquous
Copy link
Owner Author

It looks like v18.19.0 breaks but v18.18.2 is fine, based on some failing jobs today.

quisquous added a commit that referenced this issue Dec 6, 2023
@quisquous
build: temporarily limit node version (#5986)
146b25f 
Do this until a better solution for #5910 exists.
github-actions bot pushed a commit that referenced this issue Dec 6, 2023
gh-pages build: build: temporarily limit node version (#5986)
21d05aa 
Do this until a better solution for #5910 exists. 146b25f
@quisquous
Copy link
Owner Author

Hmm #5986 did not appear to do anything, so this needs to be fixed or jobs will just fail randomly if they get a too-new node version.

@quisquous quisquous mentioned this issue Dec 7, 2023
Closed
quisquous added a commit that referenced this issue Dec 7, 2023
@quisquous
build: add back loader parameter to node commands
6b2279a 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

Additionally, as `--loader` is deprecated, an error message
suggests to do in JavaScript, so add a loader script
`--import ./loader.js` to do this work instead

Fixes #5910.
Fixes #5989.
@quisquous quisquous mentioned this issue Dec 7, 2023
Merged
quisquous added a commit that referenced this issue Dec 7, 2023
@quisquous
ci: require node 18.18.2 for workflow jobs
9eb2cd1 
Without #5990, this breaks on 18.19.x and above. See: #5910.
@quisquous quisquous mentioned this issue Dec 7, 2023
Merged
quisquous added a commit that referenced this issue Dec 7, 2023
@quisquous
ci: require node 18.18.2 for workflow jobs (#5991)
90c57c2 
Without #5990, this breaks on 18.19.x and above. See: #5910.
github-actions bot pushed a commit that referenced this issue Dec 7, 2023
triggers build: ci: require node 18.18.2 for workflow jobs (#5991)
d06b694 
Without #5990, this breaks on 18.19.x and above. See: #5910. 90c57c2
github-actions bot pushed a commit that referenced this issue Dec 7, 2023
gh-pages build: ci: require node 18.18.2 for workflow jobs (#5991)
7f5f292 
Without #5990, this breaks on 18.19.x and above. See: #5910. 90c57c2
quisquous added a commit that referenced this issue Dec 20, 2023
@quisquous
build: switch to node 20, add back loader param (#5990)
4c5cf21 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via #5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes #5910.
Fixes #5989.
github-actions bot pushed a commit that referenced this issue Dec 20, 2023
triggers build: build: switch to node 20, add back loader param (#5990)
64f460b 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via #5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes #5910.
Fixes #5989. 4c5cf21
github-actions bot pushed a commit that referenced this issue Dec 20, 2023
gh-pages build: build: switch to node 20, add back loader param (#5990)
abd7e75 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via #5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes #5910.
Fixes #5989. 4c5cf21
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jan 5, 2024
gh-pages build: build: switch to node 20, add back loader param (quis…
f4e9a52 
…quous#5990)

Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes quisquous#5910.
Fixes quisquous#5989. 4c5cf21
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jan 6, 2024
triggers build: build: switch to node 20, add back loader param (quis…
6fbc2f1 
…quous#5990)

Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes quisquous#5910.
Fixes quisquous#5989. 4c5cf21
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jan 6, 2024
gh-pages build: build: switch to node 20, add back loader param (quis…
5092acf 
…quous#5990)

Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes quisquous#5910.
Fixes quisquous#5989. 4c5cf21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: switch to node 20, add back loader param quisquous/cactbot
1 participant
@quisquous