-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: upgrade ts-node for native ESM support #4211
Conversation
ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0), although according to the [related PR](TypeStrong/ts-node#1655) says, they are just spawn a child process that passed `--loader ts-node/esm` options to node itself. Also, upgrade `typescript` and `typescript-eslint` to the newer version.
|
Thanks for this. Sorry I haven't merged it yet, I wanted to look at this locally a bit more. |
What do you mean, by this? |
I mean that although |
Ah, ok! I think it'd be nice to have type checking for the dev server as well as at least some type checking for all the scripts (even if it's a separate step), but if there's some option to run swc in some places but not others and not lose any type checking coverage, that seems like an option. |
Overall though, I think this looks good. swc changes can come in some other PR. Thanks! |
ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0), although according to the [related PR](TypeStrong/ts-node#1655) says, they are just spawn a child process that passed `--loader ts-node/esm` options to node itself. Also, upgrade `typescript` and `typescript-eslint` to the newer version. 039a214
…us#4211) ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0), although according to the [related PR](TypeStrong/ts-node#1655) says, they are just spawn a child process that passed `--loader ts-node/esm` options to node itself. Also, upgrade `typescript` and `typescript-eslint` to the newer version. 039a214
…us#4211) ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0), although according to the [related PR](TypeStrong/ts-node#1655) says, they are just spawn a child process that passed `--loader ts-node/esm` options to node itself. Also, upgrade `typescript` and `typescript-eslint` to the newer version. 039a214
ts-node has native ESM support in v10.7.0 version,
although according to the related PR says,
they are just spawn a child process that passed
--loader ts-node/esm
options to node itself.
But no more painful
ExperimentalWarning: --experimental-loader is an experimental feature.
message in the output.Also, upgrade
typescript
andtypescript-eslint
to the newer version.By the way, seems like
ts-node
has addedswc
transpiler several versions ago,and according to
swc
orts-node
, that this transpiler is significantly faster a lot.But appearly
swc
has no ability to check the typescript type.So I am wondering whether or not we can switch to this one?