raidboss: convert NetRegexes.echo/message/dialog to params #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about exposing even more variables into the global namespace for user triggers. Maybe this should be under Also it sure feels like |
quisquous
added a commit
that referenced
this pull request
May 30, 2023
This is part of #4986. This is an alternative PR to #5451. In order to switch entirely over to `netRegex: { params }` style triggers, this PR adds a `gameLogType` field for `GameLog` triggers only. If specified, it will add the right `code`. Downsides: kind of awkward if `code` is already specified (and this will throw an error) Other options: * add a bunch more types so you could say `type: 'GameLogEcho'`, but this seemed much more hairy than was worth and the TriggerTypes type is already very very long * export the codes from some common location, import them everywhere, but this is even more nonsense to import so that user triggers can eval properly
quisquous
added a commit
that referenced
this pull request
May 30, 2023
This is part of #4986. This is an alternative PR to #5451. In order to switch entirely over to `netRegex: { params }` style triggers, this PR adds a `gameLogType` field for `GameLog` triggers only. If specified, it will add the right `code`. Downsides: kind of awkward if `code` is already specified (and this will throw an error) Other options: * add a bunch more types so you could say `type: 'GameLogEcho'`, but this seemed much more hairy than was worth and the TriggerTypes type is already very very long * export the codes from some common location, import them everywhere, but this is even more nonsense to import so that user triggers can eval properly
quisquous
force-pushed
the
convert_gamelog_triggers
branch
from
a952b1c
to
f5017c0
Compare
quisquous
force-pushed
the
convert_gamelog_triggers
branch
from
f5017c0
to
d9ea386
Compare
|
Given the lack of response from anybody else here, I'm just going to make a decision.
Moved to Util after some thought, and I'm going to go with this approach over #5452. |
quisquous
added a commit
that referenced
this pull request
Jun 25, 2023
quisquous
added a commit
that referenced
this pull request
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4986.
Closes #5452.