raidboss: fix inconsistent "soon" timeline colors #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Largely the issue here is that each timeline bar has an id, and the timeout to recolor a bar to be "soon" was looking by id. If the timeline ever got adjusted due to syncs or jumps, then the soon timer would end up firing for bars at different times. To fix this, instead have the soon timer refer to the html element directly rather than an indirect id. Track and clear this (to avoid outstanding useless timeouts) if the bar is ever removed. While we're here, also refactor the expiring timeout into the same structure. Fixes #627.
|
If anybody has any time to just test this and make sure nothing looks weird with timelines, I'd appreciate it, otherwise I'll just run with this next week and land it after that if I don't see anything. It's probably ok, but this code doesn't get changed much and so just being careful about breaking things. |
|
I'll try to check this for Tuesday evening assuming Ravahn gets things set up in time. |
|
Everything looked fine tonight. Nothing went weird on jumps or duration windows that I noticed. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
) Largely the issue here is that each timeline bar has an id, and the timeout to recolor a bar to be "soon" was looking by id. If the timeline ever got adjusted due to syncs or jumps, then the soon timer would end up firing for bars at different times. To fix this, instead have the soon timer refer to the html element directly rather than an indirect id. Track and clear this (to avoid outstanding useless timeouts) if the bar is ever removed. While we're here, also refactor the expiring timeout into the same structure. Fixes #627. 38f6742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely the issue here is that each timeline bar has an id, and the timeout to recolor a bar to be "soon" was looking by id. If the timeline ever got adjusted due to syncs or jumps, then the soon timer would end up firing for bars at different times.
To fix this, instead have the soon timer refer to the html element directly rather than an indirect id.
Track and clear this (to avoid outstanding useless timeouts) if the bar is ever removed.
While we're here, also refactor the expiring timeout into the same structure.
Fixes #627.