Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: fix p10s jade passage wrong output #5591

Merged
merged 1 commit into from
Jun 21, 2023
Merged

raidboss: fix p10s jade passage wrong output #5591

merged 1 commit into from
Jun 21, 2023

Conversation

lsl1225
Copy link
Contributor

@lsl1225 lsl1225 commented Jun 20, 2023

Just played p10s in games, and it seems the result is opposite, still need someone to take further testing.

Just played p10s in games, and it seems the result is opposite, still need someone take further testing.
@wexxlee
Copy link
Contributor

wexxlee commented Jun 20, 2023

Looking back at the original PR (#5574 ) that added this trigger, I think the assumption was that the largest potential y-value for the combatants (114) was lines, but it isn't.

The bits don't align perfectly with boxes or lines - there some vertical drift from north to south. Here's a screenshot showing the bits at [88, 92, 96, 100, 104, 108, 112], and you can see the drift:

image

Assuming the positioning of the bits in this screenshot is best described as being on 'lines' (which, I guess, is probably as good as we can get) -- then the trigger should return output.boxes!() to tell users to stand inside the boxes. Right now, it returns output.lines!(), so I think this PR is a good fix.

@Legends0
Copy link
Contributor

Legends0 commented Jun 21, 2023

As wexxlee mentioned, it's an approximation. I realize in game if you are at the south end, (last row), it ends up being off whether or not it is lines/boxes, so unless you are middle of the arena, it's iffy how much the change is worth (from the previous PR towards just having said avoid lasers). Unsure if there is anything better it could say.

@quisquous quisquous merged commit 6bec90a into quisquous:main Jun 21, 2023
github-actions bot pushed a commit that referenced this pull request Jun 21, 2023
Just played p10s in games, and it seems the result is opposite, still
need someone to take further testing. 6bec90a
github-actions bot pushed a commit that referenced this pull request Jun 21, 2023
Just played p10s in games, and it seems the result is opposite, still
need someone to take further testing. 6bec90a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants